This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Correct 5ded6212-e8d4-4206-9025-cb5991bd2f80.md (Insert text into cell) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addition adds a statement comparing the column string lengths to determine if they are the same before sorting the strings. Without the addition, the String.Compare will mistakenly insert cell AA1 before B1 leading to a corrupted file.
|
Hi @CCAchris, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
laschultz
added a commit
that referenced
this pull request
Mar 11, 2016
Correct 5ded6212-e8d4-4206-9025-cb5991bd2f80.md (Insert text into cell)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra line of code to both the c# and vb sections to correct a bug that occurs when inserting a new cell with a column name greater than Z. The existing code mistakenly inserts cell AA1 in front of B1. The addition of the string length comparison ensures that the column string lengths are the same before sorting the strings.