Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added upgrade action for the bold upgrade #340

Merged
merged 73 commits into from
Aug 21, 2023
Merged

Added upgrade action for the bold upgrade #340

merged 73 commits into from
Aug 21, 2023

Conversation

yahgwai
Copy link
Contributor

@yahgwai yahgwai commented Jun 26, 2023

Contains the upgrade action contract for migrating to the BOLD challenge protocol

This is currently missing

  1. Script to deploy the implementations and the upgrade action contract itself - prepareUpgrade
  2. Script to populate the pre-image lookup at upgrade execution time - populateUpgradeLookup
  3. Tests for the action contract itself
  4. Verification to ensure the upgrade took place correctly

@yahgwai yahgwai requested review from DZGoldman and gzeoneth June 26, 2023 13:41
gzeoneth
gzeoneth reviewed Jul 5, 2023
View reviewed changes
contracts/src/rollup/BOLDUpgradeAction.sol Outdated Show resolved Hide resolved
contracts/src/rollup/BOLDUpgradeAction.sol Outdated Show resolved Hide resolved
contracts/src/rollup/BOLDUpgradeAction.sol Outdated Show resolved Hide resolved
contracts/src/rollup/BOLDUpgradeAction.sol Outdated Show resolved Hide resolved
@yahgwai yahgwai requested a review from gzeoneth July 6, 2023 12:22
gzeoneth
gzeoneth approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gzeoneth and others added 26 commits August 2, 2023 02:45
@gzeoneth
chore: remove unused import
e1c6b40
@gzeoneth
chore: nitro-contracts/pull/21
8aa8b82
@gzeoneth
chore: nitro-contracts/pull/27
dc3dc3a
@gzeoneth
chore: nitro-contracts/pull/28
d802640
@gzeoneth
chore: nitro-contracts/pull/30
5b5ed8e
@gzeoneth
chore: nitro-contracts/pull/37 and 39
46c909c
@gzeoneth
chore: nitro-contracts/pull/47
34636b5
@yahgwai
Renamed to old rollup
34658ff
@yahgwai
Updates from CR
0ff77c1
@yahgwai
Test updates
a3ff8b7
@yahgwai
Merge branch 'main' into port-old-pr
fc81e12
@yahgwai
Migration scripts and ci (#378)
962d09a
@yahgwai
Merge branch 'main' into migration
a1e155a
@yahgwai
Check inbox count isnt 0 before returning
31bad1e
@yahgwai
Merge from main
32687a8
@yahgwai
Merge from migration
1353e62
@yahgwai
Set local validators
0ffaeae
@yahgwai
Added ownership transfer to bold upgrade
bfce9a5
@yahgwai
Merge branch 'main' into port-old-pr
713f2e4
@yahgwai
Merge branch 'port-old-pr' into migration
c78b49c
@yahgwai
Updated rollup_stack test
89776b2
@yahgwai
Added genesis states to config
95bcc98
@yahgwai
Merge form main
fe1661a
@yahgwai
Merge conflict
5438ba5
@yahgwai
mod tidy
1570090
@yahgwai
Merge from main
0ba65b7
@yahgwai yahgwai merged commit a40d04e into main Aug 21, 2023
@yahgwai yahgwai deleted the migration branch August 21, 2023 10:31
@amsanghi amsanghi mentioned this pull request Sep 1, 2023
Closed
@gzeoneth gzeoneth mentioned this pull request Oct 24, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzeoneth gzeoneth gzeoneth approved these changes

@DZGoldman DZGoldman Awaiting requested review from DZGoldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahgwai @gzeoneth