Improve/ignored commands #4128
Merged
Improve/ignored commands #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
|
Accidentally closed this PR! |
|
I'm slightly worried that will once again lead to people complaining that "OctoPrint should not refuse to send commands to my printer without me knowing about it" (which is why the notifications about blocked commands was introduced in the first place), but considering that we ship it empty and a log entry and event are still generated (albeit the latter is usually ignored) this feels low risk enough. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Added Ignored Commands to the Serial Protocol settings
This is an exact duplicate of the Blocked Commands setting except that emitted event is severity
infonotwarn. The result of this is that there isn't a red popup displayed when the GCode is encountered, the information is just logged to the logfile.This is important if you are intentionally producing GCode that contains codes that your printer cannot handle (e.g
M600for filament change on a printer with a single extruder - see below for further context)How was it tested? How can it be tested by the reviewer?
Change the blocked commands to be
M0and the ignored command to beM1. SendingM0andM1in the terminal should have exactly the same effect, except that there should be no popup for theM1commandAny background context you want to provide?
To generate multicolour prints, I can specfiy that my printer has 2 extruders so that the sliced GCode will contain command like
The physical printer only has a single extruder, so I can set
M600as a pausing command (with a GCODE script to move the head safe) and manually perform a filament change.However the M600 and T1 commands in the sliced GCode will cause scary red popups to appear in the octoprint window, despite them being entirely expected and allowed for. Setting M600 and T1 as ignored commands (rather than blocked commands) will avoid the popups being displayed
What are the relevant tickets if any?
None
Screenshots (if appropriate)
Further notes
Note that by default no GCode commands are set as Ignored Commands