Feature/oed2tests #954
Merged
Feature/oed2tests #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
insurance_conditions test fail because I have been unable to update expected. the only change is to fm_programme and fm_policytc but i can't get the tests to pass. can you help please @sambles ? |
|
I've pushed the updated expected files generated from my system and they match + pass locally. Do they look correct? |
|
There are some other oed related test which need updating: model_preparation/test_oed.pyReading example example OED files from https://github.com/OasisLMF/OasisLMF/tree/master/tests/model_preparation/examples) model_preparation/test_reinsurance.pywhich is using fixed example DataFrames |
sambles
approved these changes
Dec 3, 2021
This was
linked to
issues
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to OED2
Support for OED v2.0.0 exposure input format, including
New policy conditions features supported
Validation test suite upgraded to OED 2.0.0 input format