Set pip-compile to backtracking and trim unused requirments #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtazzari
approved these changes
Dec 8, 2022
| @@ -19,7 +19,6 @@ on: | |||
| ktools_branch: | |||
| description: "Build Ktools before tests: [git ref]" | |||
| required: false | |||
| default: "develop" | |||
There was a problem hiding this comment.
is this deletion on purpose?
There was a problem hiding this comment.
yup, i missed that from the PR notes, i'll add it in.
I noticed when running a manual trigger, ktools is always built because that value is auto-filled with develop when it should probably be blank as default.
sambles
added a commit
that referenced
this pull request
Dec 8, 2022
* Set pip-compile to backtracking and trim unused requirments * Only set backtracking for python3.7
sambles
added a commit
that referenced
this pull request
Dec 8, 2022
* Set pip-compile to backtracking and trim unused requirments * Only set backtracking for python3.7
sambles
added a commit
that referenced
this pull request
Dec 8, 2022
* Set pip-compile to backtracking and trim unused requirments * Only set backtracking for python3.7
sambles
added a commit
that referenced
this pull request
Dec 9, 2022
* test ods-tools git install * Try ods_tools package install * Set pip-compile to backtracking and trim unused requirments (#1174) * Set pip-compile to backtracking and trim unused requirments * Only set backtracking for python3.7 * update ods build workflow loc * Add line to uninstall ods_tools * use "skikit-learn" instead of "sklearn" (same package) * Run pytest directly * Update script to build ods_tools on push * Remove if on build ods_tools
sambles
added a commit
that referenced
this pull request
Jan 12, 2023
* refactoring to use ods_tools * remove unused import * more pep8 * more pep8 * more pep8 * add default for RiskLevel * Feature/ods tools migration test (#1176) * test ods-tools git install * Try ods_tools package install * Set pip-compile to backtracking and trim unused requirments (#1174) * Set pip-compile to backtracking and trim unused requirments * Only set backtracking for python3.7 * update ods build workflow loc * Add line to uninstall ods_tools * use "skikit-learn" instead of "sklearn" (same package) * Run pytest directly * Update script to build ods_tools on push * Remove if on build ods_tools * fix tests * Update unittest.yml * test call to ods_tool build * test passed, merged ods fixed and set ci workflow to master * workaround python3.7 dtype conversion * Feature/ods tools migration piwind fix (#1182) * test run piwind * try piwind * update workflow branch * Always build oasislmf package before test * Fix ref * force retest * remove pr branch limit * f * Fix def * disable push - tmp * fix * Switch workflow branches * Prep for merge * add back push trig * Run autopep8 Test fix for Platform Update numpy max ver Revert "Update numpy max ver" This reverts commit 14c6c6b. Fix ods branch selection Force retest Fix exposure load revert test fix * test platform fix * Add fix to keep group_id assigment the same as prev version pep8 * Fix broken fm tests * Switch piwind workflow to use ods develop * Set min ods_tools requirment * Revert "ods_tools requirment" --- SET BEFORE RELEASE This reverts commit 06e99c8. * pep8 alignment in a few lines * Set min ods-tools package to 3.0.0 * Disable ods-tools branch builds in testing * Skip ods build unless input set * ODS tools piwind workflow * remove old import * Fix old imports Co-authored-by: sambles <sambles@users.noreply.github.com> Co-authored-by: Sam Gamble <hexadessa@gmail.com> Co-authored-by: mtazzari <mtazzari@gmail.com>
sambles
added a commit
that referenced
this pull request
Jan 12, 2023
* refactoring to use ods_tools * remove unused import * more pep8 * more pep8 * more pep8 * add default for RiskLevel * Feature/ods tools migration test (#1176) * test ods-tools git install * Try ods_tools package install * Set pip-compile to backtracking and trim unused requirments (#1174) * Set pip-compile to backtracking and trim unused requirments * Only set backtracking for python3.7 * update ods build workflow loc * Add line to uninstall ods_tools * use "skikit-learn" instead of "sklearn" (same package) * Run pytest directly * Update script to build ods_tools on push * Remove if on build ods_tools * fix tests * Update unittest.yml * test call to ods_tool build * test passed, merged ods fixed and set ci workflow to master * workaround python3.7 dtype conversion * Feature/ods tools migration piwind fix (#1182) * test run piwind * try piwind * update workflow branch * Always build oasislmf package before test * Fix ref * force retest * remove pr branch limit * f * Fix def * disable push - tmp * fix * Switch workflow branches * Prep for merge * add back push trig * Run autopep8 Test fix for Platform Update numpy max ver Revert "Update numpy max ver" This reverts commit 14c6c6b. Fix ods branch selection Force retest Fix exposure load revert test fix * test platform fix * Add fix to keep group_id assigment the same as prev version pep8 * Fix broken fm tests * Switch piwind workflow to use ods develop * Set min ods_tools requirment * Revert "ods_tools requirment" --- SET BEFORE RELEASE This reverts commit 06e99c8. * pep8 alignment in a few lines * Set min ods-tools package to 3.0.0 * Disable ods-tools branch builds in testing * Skip ods build unless input set * ODS tools piwind workflow * remove old import * Fix old imports Co-authored-by: sambles <sambles@users.noreply.github.com> Co-authored-by: Sam Gamble <hexadessa@gmail.com> Co-authored-by: mtazzari <mtazzari@gmail.com>
sambles
added a commit
that referenced
this pull request
Jan 18, 2023
* Set pip-compile to backtracking and trim unused requirments * Only set backtracking for python3.7
sambles
added a commit
that referenced
this pull request
Jan 18, 2023
* Set pip-compile to backtracking and trim unused requirments * Only set backtracking for python3.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI bug with pip compile
requirements.inwhich are not needed for CI testing, these have been removed.unittest.yml, it now won't build ktools unless a branch is given as input.