Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/package install error #1133

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Fix/package install error #1133

merged 4 commits into from
Nov 7, 2022

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Oct 21, 2022 •
edited
Loading

Fix Package requirements

Add Scipy to required packages

From #1069 the package scipy is used without being included in requirements-package.in

OasisLMF/requirements-package.in

Lines 1 to 19 in e0b0639

anytree>=2.4.3
argparsetree>=0.0.5
chainmap
chardet
fastparquet>=0.3.1
jsonschema
msgpack
numba>=0.55.1
numexpr
ods-tools>=2.3.2
pandas>=1.0.3,!=1.1.0,!=1.1.1
pytz
requests>=2.20.0
requests-toolbelt
shutilwhich
tabulate>=0.8.2
tblib
tqdm
numpy<1.22,>=1.18

OasisLMF/oasislmf/pytools/gul/random.py

Line 9 in e0b0639

from scipy.stats import norm

Update Numpy maximum version

Platform docker builds fail due to the pinned numpy version, this was fixed in version 1.26.3 but that change didn't get merged back into develop from the branches diverging.

Issue fixed with this PR instead of a merge back from backports/1.26.x.

numpy==1.22.4 and oasislmf[extra]==<develop> because these package versions have conflicting dependencies.
The conflict is caused by:
    The user requested numpy==1.22.4
    fastparquet 0.8.0 depends on numpy>=1.18
    numba 0.55.2 depends on numpy<1.23 and >=1.18
    numexpr 2.8.1 depends on numpy>=1.13.3
    pandas 1.5.1 depends on numpy>=1.20.3; python_version < "3.10"
    pyarrow 8.0.0 depends on numpy>=1.16.6
    scikit-learn 1.1.2 depends on numpy>=1.17.3
    scipy 1.9.3 depends on numpy<1.26.0 and >=1.18.5
    oasislmf[extra] depends on numpy<1.22 and >=1.18

@sambles sambles force-pushed the fix/package-install-error branch from 6aea19f to ee3500b Compare November 7, 2022 11:03
@sambles sambles requested review from mtazzari and sstruzik November 7, 2022 11:04
@sambles sambles merged commit ae91f7b into develop Nov 7, 2022
@sambles sambles deleted the fix/package-install-error branch November 7, 2022 15:41
@awsbuild awsbuild modified the milestones: 1.27.0rc2, 1.27.0rc3 Nov 7, 2022
sambles added a commit that referenced this pull request Jan 12, 2023
@sambles
Fix/package install error (#1133)
d7e7ae0 
* Update numpy versions (from 1.26.x branch)

* Set to current release

* Add Scipy to package requirments
@awsbuild awsbuild modified the milestones: 1.27.0rc3, 1.27.0 Jan 12, 2023
sambles added a commit that referenced this pull request Jan 18, 2023
@sambles
Fix/package install error (#1133)
41373c8 
* Update numpy versions (from 1.26.x branch)

* Set to current release

* Add Scipy to package requirments
@awsbuild awsbuild modified the milestones: 1.27.0, 1.26.5 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtazzari mtazzari Awaiting requested review from mtazzari

@sstruzik sstruzik Awaiting requested review from sstruzik

Assignees
No one assigned
Labels
LTS - 1.26
Projects
None yet
Milestone
1.26.5
Development

Successfully merging this pull request may close these issues.
2 participants
@sambles @awsbuild