Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING guidelines #1128

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Add CONTRIBUTING guidelines #1128

merged 5 commits into from
Oct 25, 2022

Conversation

mtazzari
Copy link
Contributor

@mtazzari mtazzari commented Oct 20, 2022 •
edited
Loading

Add contributing guidelines to Fix #1129.
The proposal is to define and clarify contributing guidelines for the OasisLMF package and all the OasisLMF organization repositories.
This PR:

  • adds a CONTRIBUTING.md file with the guidelines
  • updates the PR description template with guidelines for the choice of reviewers.

Release notes feature title

We add Contributing guidelines for the OasisLMF team and for the wider community.

@mtazzari mtazzari self-assigned this Oct 20, 2022
@mtazzari mtazzari added enhancement New feature or request documentation Tasks related to documentation and other system collateral. feature A main feature, captured on the backlog and removed feature A main feature, captured on the backlog labels Oct 20, 2022
@mtazzari mtazzari linked an issue Oct 20, 2022 that may be closed by this pull request
Add contributing guidelines #1129
Closed
@mtazzari mtazzari requested a review from benhayes21 October 20, 2022 10:22
@mtazzari mtazzari marked this pull request as ready for review October 20, 2022 10:26
@mtazzari mtazzari merged commit a4f3ede into develop Oct 25, 2022
@mtazzari mtazzari deleted the feature/contributing branch October 25, 2022 15:14
@mtazzari mtazzari restored the feature/contributing branch October 25, 2022 15:14
@mtazzari mtazzari deleted the feature/contributing branch October 25, 2022 15:17
@mtazzari mtazzari mentioned this pull request Oct 25, 2022
Closed
@awsbuild awsbuild modified the milestones: 1.27.0rc2, 1.27.0rc3 Nov 7, 2022
This was referenced Nov 17, 2022
Closed
Closed
Closed
sambles pushed a commit that referenced this pull request Jan 12, 2023
@mtazzari @sambles
Add CONTRIBUTING guidelines (#1128)
2069306 
* [CONTRIBUTING] add CONTRIBUTING guidelines

* [CONTRIBUTING] add review rules to issue template

* [CONTRIBUTING] update the PR template instead

* [CONTRIBUTING] update PR template

* [CONTRIBUTING] Add Ready for review label when ready
@awsbuild awsbuild modified the milestones: 1.27.0rc3, 1.27.0 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hchagani-oasislmf hchagani-oasislmf hchagani-oasislmf approved these changes

@KamalCharles KamalCharles KamalCharles approved these changes

@sstruzik sstruzik sstruzik approved these changes

@benhayes21 benhayes21 benhayes21 approved these changes

@sambles sambles sambles approved these changes

@maxwellflitton maxwellflitton Awaiting requested review from maxwellflitton

Assignees

@mtazzari mtazzari

Labels
documentation Tasks related to documentation and other system collateral. enhancement New feature or request
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.

Add contributing guidelines
7 participants
@mtazzari @sambles @benhayes21 @sstruzik @KamalCharles @hchagani-oasislmf @awsbuild