Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code PEP8 compliant #1132

Closed
mtazzari opened this issue Oct 20, 2022 · 2 comments · Fixed by #1146
Closed

Make code PEP8 compliant #1132

mtazzari opened this issue Oct 20, 2022 · 2 comments · Fixed by #1146
Assignees
@mtazzari
Labels
enhancement New feature or request
Milestone
1.27.0

Comments

@mtazzari
Copy link
Contributor

mtazzari commented Oct 20, 2022 •
edited
Loading

Currently only portions of the codebase are PEP8 compliant.

Extend the PEP8 compliance to the full codebase.
@mtazzari mtazzari added the enhancement New feature or request label Oct 20, 2022
@mtazzari mtazzari self-assigned this Oct 20, 2022
@mtazzari mtazzari mentioned this issue Oct 20, 2022
Closed
@mtazzari mtazzari linked a pull request Oct 20, 2022 that will close this issue
Add pep8 check #1131
Closed
@mtazzari
Copy link
Contributor Author

I've closed the related PR with the GH action ready to use. The PR can be resumed when we've done a PEP8 pass to the whole codebase.

@mtazzari mtazzari mentioned this issue Nov 8, 2022
Closed
@mtazzari mtazzari linked a pull request Nov 8, 2022 that will close this issue
PEP8 pass on the whole codebase #1145
Closed
@mtazzari mtazzari mentioned this issue Nov 9, 2022
Merged
@mtazzari mtazzari linked a pull request Nov 11, 2022 that will close this issue
Apply PEP8 to the whole codebase and fix some flake8 errors #1146
Merged
@mtazzari
Copy link
Contributor Author

Fixed in #1146

@awsbuild awsbuild added this to the 1.27.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtazzari mtazzari

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.27.0
2 participants
@mtazzari @awsbuild