Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: button-bgcolor-on-hover #411

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fixed: button-bgcolor-on-hover #411

merged 1 commit into from
Jan 10, 2025

Conversation

yashgoyal0110
Copy link
Collaborator

@yashgoyal0110 yashgoyal0110 commented Jan 10, 2025 •
edited
Loading

fixes #408

fixed button background color on hover in dark-mode at five end-points:

  1. /contribute
  2. /projects
  3. /projects/'project-name'
  4. /chapters
  5. /chapters/'chapter-name'
buttonBgFixed.mp4

@yashgoyal0110
Copy link
Collaborator Author

@arkid15r any feedback on this?

arkid15r
arkid15r approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for fixing that!

@arkid15r arkid15r added this pull request to the merge queue Jan 10, 2025
@yashgoyal0110
Copy link
Collaborator Author

@arkid15r welcome😄

Merged via the queue into OWASP:main with commit 4e225b4 Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

@kasya kasya Awaiting requested review from kasya kasya is a code owner

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

button label hides on hover in dark mode
2 participants
@yashgoyal0110 @arkid15r