cronjobs: fix new version red boxes in older manuals #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inject "current manual page" red boxes at a later stage in the building process - use `NEW_CURRENT` variable to define current version only at top of script (avoid versions hardcoded in URLs)
echoix
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
I'm fine with the concept, and reading through I didn't find anything that caught my eye. I can't pronounce myself on the bash/script itself, but I assume it's more of your specialty. Since it is only for supporting the infrastructure, and you maintain it anyways, there's no reason to block it. If it's problematic it most likely will be you that will make the changes
Yes, confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW_CURRENTvariable to define current version only at top of script (avoid versions hardcoded in URLs)Needed for