v.maxent.swd: bug fixes and new option to export explanatory raster layers #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ecodiv
commented
Jan 5, 2024
ecodiv
commented
- Bug fixes
- Added option to export the raster layers used as input in the creation of the SWD file. This can be used in Maxent as projection layers.
- Bug fixes - Added option to export the raster layers used as input in the creation of the SWD file. This can be used in Maxent as projection layers.
ninsbl
requested changes
Jan 6, 2024
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
Updates based on suggestions from @ninsbl
|
Hi @ninsbl, first, thanks for the suggestions. I followed up on all your suggestions, I think, but merging is still blocked. Do you know what else I need to do to go ahead? |
ninsbl
approved these changes
Jan 7, 2024
|
@wenzeslaus could we have automerge enabled here too? It could’ve been used here |
neteler
reviewed
Jan 7, 2024
Co-authored-by: Markus Neteler <neteler@osgeo.org>
Maxent only accepts raster cells with equal ns and ew resolution. Added code that checks the region setting, and gives a fatal message if ns resolution is not ew resolution. Optionally, the user can set the -e flag. This will automatically adjust the resolution of the largest side to match that of the smallest side.
I plan to use this proj. file in r.maxent.train to check if the crs of the data used for the training matches that of the current mapset. If not, this proj. file will make it possible to import the output of r.maxent.train with reprojection (with warning). I can still have r.maxent.train issue a warning if there is no proj file, and let the user explicitly use the -o flag to override the projection check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.