Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Authz, Test] - refactor the cpp authorization class testable #1159

Open
JoshuaSBrown opened this issue Dec 4, 2024 · 0 comments · Fixed by #1161
Open

[Authz, Test] - refactor the cpp authorization class testable #1159

JoshuaSBrown opened this issue Dec 4, 2024 · 0 comments · Fixed by #1161

Comments

@JoshuaSBrown
Copy link
Collaborator

Description

The authorization class is not currently easily testable as the majority of the logic is contained in a single method. The communication logic needs to be separated from path checks and made testable.

Acceptance

Header class for the cpp authorization class is created
separate methods are created for testing the different parts of the logic i.e.

  • ftp scheme
  • path manipulation and checks
  • sending the actual message
  • creation of the communicator -> probably needs to be moved into the constructor
@JoshuaSBrown JoshuaSBrown linked a pull request Dec 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant