[16.0][FIX] mail_gateway: Pass company in order to ensure that it is executed properly #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
changed the title
pedrobaeza
reviewed
Sep 12, 2024
| @@ -113,7 +113,7 @@ def create(self, mvals): | |||
| @tools.ormcache() | |||
| def _get_gateway_map(self, state="integrated", gateway_type=False): | |||
| result = {} | |||
| for record in self.search( | |||
| for record in self.sudo().search( | |||
There was a problem hiding this comment.
Shouldn't you limit here by company in this search?
There was a problem hiding this comment.
No, because this map is intended to be used on the controller entry for the gateway, and the controller does not know the company until we check the gateway
pedrobaeza
approved these changes
Sep 12, 2024
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at fb643e3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.