Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] mail_template_substitute: Corrected method name override _onchange_template_id_wrapper #1432

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

DorianMAG
Copy link

@DorianMAG DorianMAG commented Aug 9, 2024

The name of the method on which this override was based has been renamed in the report_substitute module in the reporting-engine repository.

https://github.com/OCA/reporting-engine/blob/e444d4ead5bba908071e8abf7f6268a6f990463b/report_substitute/wizards/mail_compose_message.py#L12

The commit in question to change the signature of the method is:
OCA/reporting-engine@077bd63

Copy link

@JulienMartinez JulienMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@amkarthik amkarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@amkarthik
Copy link
Member

@OCA/social-maintainers can we get this merged?

@hbrunn
Copy link
Member

hbrunn commented Sep 11, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1432-by-hbrunn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 523c60e into OCA:16.0 Sep 11, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c76689c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants