Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to exclude the SysOp from last callers list #88

Closed
davestephens opened this issue Aug 28, 2016 · 8 comments
Closed

Ability to exclude the SysOp from last callers list #88

davestephens opened this issue Aug 28, 2016 · 8 comments

Comments

@davestephens
Copy link
Collaborator

It would be good if it was possible to exclude the sysop from the last callers list, possibly via a config option. I call my board a lot, so the last callers just ends up being a list of my calls which reduces its worth somewhat...

screenshot at 2016-08-28 15 39 06

@NuSkooler
Copy link
Owner

I think a few people would like this -- my only concern is I (personally) would only like it about 50% of the time. I'm pondering a way to optionally do this, for example logging in with !NuSkooler (note the '!' prefix) or such.

What do you think?

@davestephens
Copy link
Collaborator Author

Yeah, that's a good point - I've actually had users comment that the sysop (me) never logged in, when in actual fact I had been, just invisibly.

I'm scraping the memory banks here, was it Wildcat that had a similar feature with the exclamation mark? I think it's a nice way to do it, but I'd personally want it so that it was limited to use by the sysop/admins only.

@NuSkooler
Copy link
Owner

@davestephens It could be tied to an ACS, defaulting to GM[sysops]

@NuSkooler
Copy link
Owner

Resolved @ 64ded25

I started going down the path described above for a "silent" login. It's mostly working, but needs some additional areas. I've moved that code aside for now until I have some other more important things completed. In any case, you can now set an option in your last_callers config blocks to hide ops:

config: {
  hideSysOpLogin: true
}

I'll create a issue for the silent/stealth option.

@NuSkooler
Copy link
Owner

Reopening: The implementation I created needs some work. Currently only height items are retrieved from the DB then +ops are simply filtered out, which leaves the list shorter than it should be.

@NuSkooler
Copy link
Owner

Should be fully resolved now with 470897e:

Setting hideSysOpLogin to true like the comment above will filter out +ops but still show the full list if the filtered list ends up being too small to fill the view. You can fully disable +ops from ever showing by setting the value to 'always':

config: {
  hideSysOpLogin: always
}

@davestephens
Copy link
Collaborator Author

I think I'm being stupid - where does this config block go exactly?

@NuSkooler
Copy link
Owner

Sorry, I should clarify more: Any menu entry can have a config block with module defined options. This would go in your last callers menu.hjson declarions, e.g.:

fullLoginSequenceLastCallers: {
            desc: Last Callers
            module: last_callers
            art: LASTCALL
            options: { pause: true }
            next: fullLoginSequenceWhosOnline
            config: {
                hideSysOpLogin: true
            }
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants