-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed NuGet.config missing issue #458
Conversation
@@ -24,6 +24,8 @@ public static class NuGetConstants | |||
|
|||
public static readonly string FeedName = "nuget.org"; | |||
|
|||
public static readonly string AddV3TrackFile = "AddV3Track.config"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call the file NuGetOrgAdd.trk
and base the behavior on the existence of the file.
@@ -24,6 +24,8 @@ public static class NuGetConstants | |||
|
|||
public static readonly string FeedName = "nuget.org"; | |||
|
|||
public static readonly string AddV3TrackFile = "NuGetOrgAdd.trk"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make this all lower to avoid xplat issues like we have with nuget.config
Verify that loading the machine wide settings is cached here and isn't read an extra time just for this check. If it does we should look at checking this lazily after zero sources are found. |
Verified machine wide is cached, this check is only for appdata setting, will not read machine wide here |
|
NuGet/Home#2445
the fix here is to check nuget.config in appdata, if there is no source, add nuget.org to it and create a track file. If the track file exist, nuget will not add nuget.org again.
And this fix is only for global nuget.config.
tested upgrading from 3.3 to 3.4 scenario, it works well