polymc-unwrapped: init at 6.1, polymc: init at 6.1 #369915
Conversation
github-actions
bot
added
the
8.has: maintainer-list (update)
|
If anyone wants Mac support, I could try to figure it out, but I don't have one and frankly know nothing about them. |
github-actions
bot
added
10.rebuild-darwin: 0
wegank
added
the
12.approvals: 1
|
Shouldn't mangohud also be included as a runtime dependency along with gamemode? |
|
Also, check #160960 You might also want to alias multimc to polymc like it was before |
This is a good point, and I'll look into doing that today. Curiously, as of the latest commit in this PR, gamemode and mangohud support doesn't work on either PolyMC or PrismLauncher, both reporting that they "could not be found on your system." I'm going to investigate how the underlying code behind this finds it and possibly fix this for both launchers. cc: @Scrumplex |
orvitpng
force-pushed
the
polymc
branch
2 times, most recently
from
fa54591 to
76b6e7c
Compare
|
Scratch the part about missing |
|
I don't know about your environment, but the MangoHud toggle works fine on Prism Launcher for me. All you need to do is add I can't and don't want to speak for PolyMC in this case, as the codebases have diverged significantly. |
Well, sure. Assuming that the system environment contains MongoHud, then everything works fine. The question is whether or not that should be included within the launcher wrapper itself (just like gamemode is). If not including this is intentional, you can disregard. I guess I had assumed that you would want to include this by default! Sorry. |
wegank
removed
the
12.approvals: 1
Adds myself as a maintainer and initializes polymc-unwrapped and polymc as packages. I tried to roughly follow what the prismlauncher derivation looked like while still sticking to what PolyMC itself uses in its own derivation, so hopefully it is kind of the best of both worlds.
Closes #365781.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.