Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quran-companion: init at 1.3.2 #369912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mostafa-khaled775
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@misuzu misuzu added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 1, 2025
Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New packages should be added to pkgs/by-name/ instead of the category hierarchy.

pkgs/applications/misc/quran-companion/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/quran-companion/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/quran-companion/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/quran-companion/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/quran-companion/default.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants