Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temurin-bin: add version 24 (early access) for Linux #368598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 27, 2024

Things done

To be able to test with this version, and as preparation for when it becomes GA (which is expected to be before the next Nix release, https://www.oracle.com/java/technologies/java-se-support-roadmap.html)

I think I would ideally prefer this to live outside of nixpkgs until it becomes stable, but I don't think this is currently easy to do, and it's anyway a good stepping stone towards more fully packaging OpenJDK 24 later anyway, so I think on balance it makes sense to have it in nixpkgs.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

To be able to test with this version, and as preparation for when
it becomes GA
@github-actions github-actions bot added 6.topic: java Including JDK, tooling, other languages, other VMs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 27, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 27, 2024
@addict3d
Copy link
Contributor

addict3d commented Jan 8, 2025

Getting sources from adoptium looks reasonable. The builds work on x86_64-linux.

temurin-bin-24-x86_64-linux -> /nix/store/9zm0hv5hnb8977brjwfjmgpnr5930q86-temurin-bin-24.0.0
temurin-jre-bin-24-x86_64-linux -> /nix/store/fs6aj1jzjhxrxqr48x2afbgp7v46iasg-temurin-jre-bin-24.0.0`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: java Including JDK, tooling, other languages, other VMs 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants