nixos/oci-containers: support rootless containers & healthchecks #368565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes NixOS#259770 Closes NixOS#207050 The motivation for the former is to not execute the container as root, so you don't have to `sudo -i` to perform podman management tasks. The idea behind healthchecks is to be able to keep the unit in the activating state until the container is healthy, only then then unit is marked as active. The following changes were necessary: * Move the ctr-id into `/run/${containerName}` to make podman can actually write to it since it's now in its RuntimeDirectory. * Make `sdnotify` option configurable (`healthy` for healthchecks that must pass, default remains `conmon`). * Set Delegate=yes for `sdnotify=healthy` to make sure a rootless container can actually talk to sd_notify[1]. * Add a warning that lingering must be enabled to have a `systemd --user` instance running which is required for the cgroup support to work properly. * Added a testcase for rootless containers with both conmon and healthchecks. [1] containers/podman#20573 (comment)
github-actions
bot
added
6.topic: nixos
Ma27
commented
Dec 27, 2024
| type = types.enum [ | ||
| "conmon" | ||
| "healthy" | ||
| "container" |
There was a problem hiding this comment.
Note: this probably requires some testing before merging. I haven't really verified if all the settings are correct for this case.
Ma27
commented
Dec 27, 2024
| ) "network-online.target"; | ||
| wants = | ||
| lib.optional (container.imageFile == null && container.imageStream == null) "network-online.target" | ||
| ++ lib.optional dependOnLingerService "linger-users.service"; |
There was a problem hiding this comment.
Still kinda amazing, how this is the result of an RFC that has
We want a unified Nix code style that's consistent with itself, easily readable, accessible and results in readable diffs.
(emphasis mine) as explicit goal.
github-actions
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/podman-rootless-with-systemd/23536/13 |
megheaiulian
approved these changes
Jan 8, 2025
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259770
Closes #207050
The motivation for the former is to not execute the container as root, so you don't have to
sudo -ito perform podman management tasks.The idea behind healthchecks is to be able to keep the unit in the activating state until the container is healthy, only then then unit is marked as active.
The following changes were necessary:
Move the ctr-id into
/run/${containerName}to make podman can actually write to it since it's now in its RuntimeDirectory.Make
sdnotifyoption configurable (healthyfor healthchecks that must pass, default remainsconmon).Set Delegate=yes for
sdnotify=healthyto make sure a rootless container can actually talk to sd_notify[1].Add a warning that lingering must be enabled to have a
systemd --userinstance running which is required for the cgroup support to work properly.Added a testcase for rootless containers with both conmon and healthchecks.
[1] containers/podman#20573 (comment)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.