Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsm-client: 8.1.24.0 -> 8.1.25.0 (and update URLs) #365012

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tsm-client: 8.1.24.0 -> 8.1.25.0 (and update URLs) #365012

wants to merge 2 commits into from
+7 −20

Conversation

Yarny0
Copy link
Contributor

@Yarny0 Yarny0 commented Dec 13, 2024

  • Update some URLs (mainly comments) in the tsm-client package to adapt to new IBM website structure.
  • Update tsm-client to newest version, released today.

Note: The observation from #345039 (comment) persists, but also still does not cause any problems as far as I can observe (see also #345039 (comment)).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

More:

  • Both test derivations (cli and gui) build/pass.
  • Successfully tested with a real tsm-server: uploaded some files for backup without errors/problems.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 2 packages built:
  • tsm-client
  • tsm-client-withGui

Add a 👍 reaction to pull requests you find important.

@Yarny0
tsm-client: update support URLs
33d4a53 
IBM changed their website URLs.

The previous link to "Hardware and Software Requirements"
(explaining optional dependencies like acl and lvm)
disappeared and I can't find a new public link.
As the information still seems correct
(e.g. libdevmapper still enables additional functionality,
as can be deduced from
https://www.ibm.com/docs/en/storage-protect/8.1.24?topic=errors-resolving-linux-image-backup ),
I replaced the URL with a link to the web archive.

The download explanation is no longer necessary;
new versions can be found directly on the `downloadPage` now.
@Yarny0
tsm-client: 8.1.24.0 -> 8.1.25.0
2f85e96 
Readme: https://www.ibm.com/support/pages/node/597891#Readme_8125
(At the time of this writingn,
most URLs in there lead to a login portal.
This might change with time.)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 13, 2024
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 14, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yarny0 @nixos-discourse