Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lighthouse: 5.3.0 -> 6.0.0 #361181

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

lighthouse: 5.3.0 -> 6.0.0 #361181

wants to merge 1 commit into from

Conversation

centromere
Copy link
Member

Release notes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from philipmw December 3, 2024 06:42
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 3, 2024
@centromere
Copy link
Member Author

Does anyone know how to fix this build issue?:

cp: cannot stat '/nix/store/kr2svmhylbmrysp5w488h22n2ynzv811-xdelta3-rs-50d63cd/xdelta3/xdelta3/py-compile': No such file or directory

The problem is that the vendored Rust dependency (a git repository, not a crate) contains a symlink to nowhere, but I do not know how to override this.

@rolfschr
Copy link
Contributor

rolfschr commented Jan 12, 2025 •
edited
Loading

So the problem is the copy operation from here that wants to derefence the symlink. Interestingly, sigp knows about the problematic file (Note: sigp has build a crate around the original xdelta3 and pinned to a certain revision, this other rev does not have this dangling symlink).

I don't know what the best approach is. I guess the cp is fine (and too deep) to modify it, maybe some nixpkgs Rust maintainer knows better. Excluding a file that a also excluded in the cargo.toml during the copy operation would be great. Maybe building xdelta3-rs ourselves before feeding it into lighthouse would work well. I guess we could then just remove the file upfront (after unpacking?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipmw philipmw philipmw approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@centromere @rolfschr @philipmw