common-updater-scripts: update-source-version option to update SOURCE_DATE_EPOCH #358569
Conversation
…_DATE_EPOCH Adds an option to conveniently update the SOURCE_DATE_EPOCH attr
github-actions
bot
added
the
6.topic: updaters
|
This looks reasonable to me. Perhaps it's safe/simple enough to not need a test, but is there a package you could apply this to, so we can see the feature 'in action'? |
|
Sorry for not reviewing this sooner. Would not separate invocation with This is quite niche and generally, I would like the trim the arguments down a bit in favour of more generic ones. |
@raboof I had tested it and prepared a branch using this change for q2pro here
@jtojnar I haven't really considered that before. I tried it and It does indeed work for my use case. That said, I don't feel that the approach is very clear. Perhaps it would be worthwhile to allow this script to set a variable number of generic attributes in a single invocation? Something like: update-source-version "$attr" "$version" --rev="$rev" -a revCount=1234 -a SOURCE_DATE_EPOCH=2025-01-02 |
Adds an update-source-version option to conveniently update the
SOURCE_DATE_EPOCHattr.This is useful for update scripts that need to update
SOURCE_DATE_EPOCHwith each version update. It can also be seen as a step in the direction mentioned in #256270 (comment).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.