Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubikey-manager-qt: remove #357071

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

yubikey-manager-qt: remove #357071

wants to merge 1 commit into from

Conversation

avdv
Copy link
Member

@avdv avdv commented Nov 18, 2024

It was broken and is no longer actively developed.

One should use yubioath-flutter instead.

Fixes #353582

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

It was broken and is no longer actively developed.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 18, 2024
@m1dugh m1dugh added the backport release-24.11 Backport PR automatically label Nov 18, 2024
@m1dugh m1dugh added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 18, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 19, 2024
@Aleksanaa Aleksanaa removed the backport release-24.11 Backport PR automatically label Nov 30, 2024
@Aleksanaa
Copy link
Member

Not backporting as it's not broken now. If anyone continues to use it, we may need to revisit the need to remove it at this time

@Aleksanaa Aleksanaa added awaiting_changes (old Marvin label, do not use) and removed awaiting_changes (old Marvin label, do not use) labels Dec 5, 2024
@Aleksanaa Aleksanaa marked this pull request as draft December 6, 2024 15:05
@Pandapip1
Copy link
Contributor

Pandapip1 commented Jan 12, 2025

Not sure what you mean about "it's not broken". It definitely is for me!

EDIT: Never mind, it does work. I guess my nix profile upgrade --all yesterday didn't upgrade it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yubikey-manager-qt: yubikey doesn't detected with error
4 participants