home-assistant-custom-components.dreame-vacuum: init at 1.0.4, python312Packages.py-mini-racer: init at 0.6.0 #356473
Conversation
|
nixpkgs-review output: |
ofborg
bot
added
8.has: package (new)
|
@mweinelt @natsukium Bumping this PR |
|
|
||
| buildPythonPackage rec { | ||
| pname = "py-mini-racer"; | ||
| version = "0.6.0"; |
There was a problem hiding this comment.
| version = "0.6.0"; | |
| version = "0.6.0"; | |
| pyproject = true; |
and configure build-system.
| rev = "v${version}"; | ||
| sha256 = "sha256-r6ghH1uPbnM4cruxgcOkHv3HsC29p3fILtH3Mzpy8yQ="; |
There was a problem hiding this comment.
| rev = "v${version}"; | |
| sha256 = "sha256-r6ghH1uPbnM4cruxgcOkHv3HsC29p3fILtH3Mzpy8yQ="; | |
| tag = "v${version}"; | |
| hash = "sha256-r6ghH1uPbnM4cruxgcOkHv3HsC29p3fILtH3Mzpy8yQ="; |
| owner = "sqreen"; | ||
| repo = "PyMiniRacer"; |
There was a problem hiding this comment.
This repository is deprecated. The successor is https://github.com/bpcreech/PyMiniRacer.
| sha256 = "sha256-r6ghH1uPbnM4cruxgcOkHv3HsC29p3fILtH3Mzpy8yQ="; | ||
| }; | ||
|
|
||
| doCheck = false; |
| src = fetchFromGitHub { | ||
| inherit owner; | ||
| repo = "dreame-vacuum"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
| rev = "v${version}"; | |
| tag = "v${version}"; |
| lib, | ||
| buildHomeAssistantComponent, | ||
| fetchFromGitHub, | ||
| python312Packages, |
There was a problem hiding this comment.
Never consume python312Packages in home-assistant-custom-components. You must consume the same package set that home-assistant provides. To that end you can just consume the dependencies up here.
| python312Packages, | |
| numpy, | |
| pillow, | |
| ..., |
And please sort this list.
| hash = "sha256-LeKD2dIeC/TsOl3Q2TLFQy7RjzbRwYmvKUUm3JVsz8E="; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = with python312Packages; [ |
There was a problem hiding this comment.
| propagatedBuildInputs = with python312Packages; [ | |
| dependencies = [ |
| pillow | ||
| numpy | ||
| pybase64 | ||
| requests | ||
| pycryptodome | ||
| python-miio | ||
| py-mini-racer | ||
| tzlocal | ||
| paho-mqtt |
|
The cherry on top is that this package requires a native v8 library, that is built as part of the release process with no security guarantees at all. |
|
Can I suggest you look into https://github.com/Hypfer/Valetudo instead? 🤔 |
|
I wanted to avoid flashing robot firmware since it requires a custom PCB board and this component works locally too although without map support. |
|
Shoot. I have this PCB in our hackerspace, but we're probably hundreds of kilometers apart. |
|
Czech Republic is not far from Germany but I don't feel like taking a trip just for this PCB 😅 |
|
Unfortunately it is not a spare part and we only have the one. Every other month somebody comes by to use it to flash their new vacuum here. I suggest asking around hacker- and maker spaces in the Czech Republic or on Valetudo's Telegram group. |
Adds dreame-vacuum custom component for controlling Dreame Robots.
Also adds py-mini-racer python library which is required by dreame-vacuum.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.