tsm-client: 8.1.23.0 -> 8.1.24.0 #345039
Merged
tsm-client: 8.1.23.0 -> 8.1.24.0 #345039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, all URLs in package and module comments are updated.
At the time of this writing, the "Update History" page
(release notes) for tsm-client >=8.1.19 does not list any
"APARs" ("Authorized Program Analysis Reports") for 8.1.24.0.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
11.by: package-maintainer
|
Is this expected? |
|
Result of 2 packages blacklisted:
2 packages built:
|
Uh-ou .. no, I didn't expect that. This is new, but it doesn't affect core functionality. It seems they changed something about their ssl libraries. I played around a bit with openssl and patchelf and finally managed to patch these incompatibility messages away with this patch: patchdiff --git i/pkgs/by-name/ts/tsm-client/package.nix w/pkgs/by-name/ts/tsm-client/package.nix
index bf65c8d0cadc..d9850f1934e7 100644
--- i/pkgs/by-name/ts/tsm-client/package.nix
+++ w/pkgs/by-name/ts/tsm-client/package.nix
@@ -14,6 +14,7 @@
, jdk # Java GUI (needed for `enableGui`)
, buildEnv
, makeWrapper
+, openssl_3_3
, enableGui ? false # enables Java GUI `dsmj`
# path to `dsm.sys` configuration files
, dsmSysCli ? "/etc/tsm-client/cli.dsm.sys"
@@ -161,6 +162,16 @@ let
do
ln --symbolic --force --no-target-directory "$out$(readlink "$link")" "$link"
done
+ autoPatchelf -- $out
+ '';
+
+ dontAutoPatchelf = true;
+
+ postFixup = ''
+ for so in $out/opt/tivoli/tsm/client/ba/bin/plugins/netappmgm/{libssl.so.3,libcurl.so}
+ do
+ patchelf --set-rpath "${lib.makeLibraryPath [ openssl_3_3 ]}:$(patchelf --print-rpath $so)" $so
+ done
'';
});However, I'm reluctant to adding this code to the pull request (that's why I'm documenting it here instead): Those libraries seem to be related to some "NetApp" connectivity. I'm not using this and I cannot judge if that is improved or otherwise changed in any way by the patch above. I suspect that IBM's itention here is that those libraries are linked within the package and something went wrong ... and is hopefully fixed in the next release. If the patch above is applied, it might break whatever those libraries attempt to accomplish with the next update. Therefore I suggest to not touch this now and wait if a user of the NetApp functionality comes up with a bug report. Then, with the help of that user, we should be able to find a sustainable solution. What do you think about this, @pbsds ? |
|
Great investigative work! If you the maintainer is not comfortable shipping a patch then i'm fine leaving it |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update
tsm-clientto newest version, published 2024-09-27 .Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)More:
Result of
nixpkgs-reviewrun on x86_64-linux 11 package blacklisted:
2 packages built:
Add a 👍 reaction to pull requests you find important.