kicad-unstable: b7b64d959f -> 59575c19d8 #335314

uzytkownik · 2024-08-17T07:59:18Z

Description of changes

Bump version of kicad-unstable so it can be build on nix unstable channel.
kicad and kicad-testing are still failing as the libgit2 patch is not on kicad 8.0 branch.

The test failed due to lack of X server.

Issues #335003 and #327181.

Things done

Add a 👍 reaction to pull requests you find important.

uzytkownik · 2024-08-17T08:02:32Z

@evils

jfly · 2024-08-20T22:56:59Z

pkgs/applications/science/electronics/kicad/base.nix

+  doCheck = (stable || testing);
+  doInstallCheck = !debug && (stable || testing);


I don't understand what's going on here. Is this related to your comment about "The test failed due to lack of X server."?

Is the comment on line 191 ("debug builds fail all but the python test") still accurate? It feels like it has bit-rotted in light of the changes here.

I don't understand what's going on here. Is this related to your comment about "The test failed due to lack of X server."?

Yes

Is the comment on line 191 ("debug builds fail all but the python test") still accurate? It feels like it has bit-rotted in light of the changes here.

No idea. The stable and testing build is broken due to libgit2 update so I cannot check it.

I'll defer to @evils on this, but I believe we should make more of an effort to run the tests. Can we skip the problematic tests? If we cannot, we should leave a comment explaining why we're skipping the tests.

I don't disagree but I lack knowledge how to debug tests in nix sandbox.

Yeah, that's challenging. I find it can be helpful to get an interactive environment that's similar to the sandbox: https://wiki.nixos.org/wiki/Nixpkgs/Create_and_debug_packages#Using_nix-shell_for_package_development. That might help you?

@jfly The problem is missing fontconfig file:

INFO cli_util:utils.py:36 Executing command "kicad-cli sch export pdf --pages 1 -o /build/source/qa/tests/output/cli/basic_test.pone.pdf /build/source/qa/data/cli/basic_test/basic_test.kicad_sch" _ test_sch_export_pythonbom[cli/basic_test/basic_test.kicad_sch-basic_test.pythonbom-6-cli_args0] _ kitest = <conftest.KiTestFixture object at 0x7fff6e6248c0> test_file = 'cli/basic_test/basic_test.kicad_sch' output_fn = 'basic_test.pythonbom', line_skip_count = 6, cli_args = [] @pytest.mark.parametrize("test_file,output_fn,line_skip_count,cli_args", [("cli/basic_test/basic_test.kicad_sch", "basic_test.pythonbom", 6, []) ]) def test_sch_export_pythonbom( kitest, test_file: str, output_fn: str, line_skip_count: int, cli_args: List[str] ): input_file = kitest.get_data_file_path( test_file ) compare_filepath = kitest.get_data_file_path( "cli/basic_test/{}".format( output_fn ) ) output_filepath = kitest.get_output_path( "cli/" ).joinpath( output_fn ) command = ["kicad-cli", "sch", "export", "python-bom"] command.extend( cli_args ) command.append( "-o" ) command.append( str( output_filepath ) ) command.append( input_file ) stdout, stderr, exitcode = utils.run_and_capture( command ) assert exitcode == 0 > assert stderr == '' E AssertionError: assert 'Fontconfig e...ile: (null)\n' == '' E E + Fontconfig error: Cannot load default config file: No such file: (null)

Test passes in this environment

How do I do debug build?

Also any idea how do I turn off those tests. It takes me over an hour for trimmed build (just -unstable) so I move slowly and can look at this just 1-2 times/week.

@jfly I disabled only the tests that fail and added note for debug build.

jfly · 2024-08-20T22:58:05Z

pkgs/applications/science/electronics/kicad/base.nix

@@ -100,6 +101,7 @@ stdenv.mkDerivation rec {
    # https://gitlab.com/kicad/code/kicad/-/issues/17133
    "-DCMAKE_CTEST_ARGUMENTS='--exclude-regex;qa_spice'"
  ]
+  ++ optional (!stable) "-DProtobuf_DIR=${protobuf}"


Is the the expression here just !stable, but down below it's !stable && !testing?

Should we extract all this into a let needsProtobuf = ... at the top of this file?

It should be !stable && !testing. Should it be extracted to let needsProtobuf or let unstable?

let needsProtobuf feels more correct to me. Eventually it should evolve into let needsProtobuf = true, and then people will realize they can remove it enitrely. Whereas, let unstable feels more likely to stick around forever.

nixos-discourse · 2024-09-01T22:44:19Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tests-are-failing-due-to-missing-fontconfig-config/51487/3

FliegendeWurst · 2024-12-20T16:36:14Z

Hmm.. I just tried this update on staging-next and it doesn't build there.
Unfortunately the latest upstream version:

diff --git a/pkgs/applications/science/electronics/kicad/base.nix b/pkgs/applications/science/electronics/kicad/base.nix
index cf21081d149c..09d7ae37247b 100644
--- a/pkgs/applications/science/electronics/kicad/base.nix
+++ b/pkgs/applications/science/electronics/kicad/base.nix
@@ -47,6 +47,8 @@
 , libngspice
 , valgrind
 , protobuf
+, nng
+, mbedtls
 
 , stable
 , testing
@@ -188,6 +190,8 @@ stdenv.mkDerivation rec {
     unixODBC
     libdeflate
     opencascade-occt
+    nng
+    mbedtls
   ]
   ++ optional needsProtobuf protobuf
   ++ optional (withScripting) wxPython
diff --git a/pkgs/applications/science/electronics/kicad/versions.nix b/pkgs/applications/science/electronics/kicad/versions.nix
index 983f8815000d..a4ed6a433700 100644
--- a/pkgs/applications/science/electronics/kicad/versions.nix
+++ b/pkgs/applications/science/electronics/kicad/versions.nix
@@ -47,23 +47,23 @@
   };
   "kicad-unstable" = {
     kicadVersion = {
-      version =			"2024-09-09";
+      version =			"2024-12-20";
       src = {
-        rev =			"59575c19d87b6bc01344844bcab4ac1718585b7c";
-        sha256 =		"sha256-ahKL56wJUxwH6rAbhmNwXNKGWA0mqcdpa9W7mBpjgjY=";
+        rev =			"3a7aa7b6601b7ba3325abc3e978576953e380ff4";
+        sha256 =		"04xz2gbdwr374zpzlmrswrf438lhqqba1w3b11fyrpsqsflr4is5";
       };
     };
     libVersion = {
-      version =			"2024-09-09";
+      version =			"2024-12-20";
       libSources = {
-        symbols.rev =		"f34ca0fe4d703626a2e548d587ebcb49dbf1cf6a";
-        symbols.sha256 =	"sha256-zv7aZWMeiy/NiqpsxnitPp1GR93DPpo7uFSt5xB5aIs=";
-        templates.rev =		"b65257c57a6222d67db23a6d2b205600e3bf4c9a";
-        templates.sha256 =	"sha256-6jNq2ZCeEDPwRGY1Av9crTu72rqYIom+EjDJPWbmLQ4=";
-        footprints.rev =	"70c89e2a017e52de1a86c23a6c6799da232d3033";
-        footprints.sha256 =	"sha256-3N6cyDyYQrBcbBfjIfnXSpD6xQTDBY/6nkdMN/Ty4Hg=";
-        packages3d.rev =	"eef24e75adc1d7a09e987b00fee9967b29aedd2e";
-        packages3d.sha256 =	"sha256-UVVggKKvHIkkiZdKTdvYW3tCC5nzSgtW5qB/MzZm0Q8=";
+        symbols.rev =		"41b48e1d82a6d25a19140c064c23f2dc18a23e66";
+        symbols.sha256 =	"0z5hxr2w3jddfskavvmzhb8sik6rbf2q4w489yrr3c4phnlbp513";
+        templates.rev =		"5b7c6099d9b6676c95ca336ce46c16da4da7e0bb";
+        templates.sha256 =	"1vpfh7ihi00c2cjla24a2dm4cwlrklivbig5zihrylj3185p01cr";
+        footprints.rev =	"03ed358c5a274aec3c90121bbc9e03fb571ce57e";
+        footprints.sha256 =	"1vmhxc1bm456dl74b5q7w5skg5g168k3zbgx2v51ifa2k3lcv30d";
+        packages3d.rev =	"90551c40514433d1c50ad60603ae0c9099bbd8e7";
+        packages3d.sha256 =	"035xf7lny8gis334p6vvyixib04klbla81glnl8hvz8h608bg1ws";
       };
     };
   };

results in an error about mbedtls:

/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_ssl_handshake'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_ssl_conf_dbg'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_ssl_set_hostname'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_ssl_free'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_ssl_conf_psk'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_ssl_close_notify'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_x509_crl_init'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_ssl_get_peer_cert'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `mbedtls_ssl_config_init'
/nix/store/ig90vk880c1pyqb3gijx889n6n8776ql-binutils-2.43.1/bin/ld: ../common/libkicommon.so.8.99.0: undefined reference to `psa_crypto_init'

FliegendeWurst

^ see last comment (this review blocks merging)

NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 17, 2024

uzytkownik mentioned this pull request Aug 17, 2024

Package request: Update kicad-unstable version #334877

Closed

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 17, 2024

jfly mentioned this pull request Aug 20, 2024

kicad: use python 3.12, kikit: use python 3.12 #336124

Merged

13 tasks

jfly reviewed Aug 20, 2024

View reviewed changes

uzytkownik force-pushed the kicad-unstable-testin branch from 48c6851 to 17546b6 Compare August 25, 2024 18:20

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 25, 2024

uzytkownik force-pushed the kicad-unstable-testin branch from 17546b6 to 1c062b9 Compare August 31, 2024 23:10

uzytkownik changed the title ~~kicad-unstable: b7b64d959f -> 6641183d09~~ kicad-unstable: b7b64d959f -> c22eac2fbf Aug 31, 2024

kicad-unstable: b7b64d959f -> 59575c19d8

13456cc

uzytkownik force-pushed the kicad-unstable-testin branch from 1c062b9 to 13456cc Compare September 10, 2024 16:53

uzytkownik requested a review from jfly September 10, 2024 16:54

uzytkownik changed the title ~~kicad-unstable: b7b64d959f -> c22eac2fbf~~ kicad-unstable: b7b64d959f -> 59575c19d8 Sep 10, 2024

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 10, 2024

FliegendeWurst approved these changes Nov 14, 2024

View reviewed changes

FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 14, 2024

FliegendeWurst requested changes Jan 11, 2025

View reviewed changes

FliegendeWurst marked this pull request as draft January 11, 2025 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kicad-unstable: b7b64d959f -> 59575c19d8 #335314

kicad-unstable: b7b64d959f -> 59575c19d8 #335314

uzytkownik commented Aug 17, 2024

uzytkownik commented Aug 17, 2024

jfly Aug 20, 2024

uzytkownik Aug 24, 2024

jfly Aug 24, 2024

uzytkownik Aug 24, 2024

jfly Aug 24, 2024

uzytkownik Aug 31, 2024

uzytkownik Aug 31, 2024

uzytkownik Aug 31, 2024

uzytkownik Sep 10, 2024

jfly Aug 20, 2024

uzytkownik Aug 24, 2024

jfly Aug 24, 2024

uzytkownik Aug 31, 2024

nixos-discourse commented Sep 1, 2024

FliegendeWurst commented Dec 20, 2024

FliegendeWurst left a comment

		doCheck = (stable \|\| testing);
		doInstallCheck = !debug && (stable \|\| testing);

kicad-unstable: b7b64d959f -> 59575c19d8 #335314

Are you sure you want to change the base?

kicad-unstable: b7b64d959f -> 59575c19d8 #335314

Conversation

uzytkownik commented Aug 17, 2024

Description of changes

Things done

uzytkownik commented Aug 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nixos-discourse commented Sep 1, 2024

FliegendeWurst commented Dec 20, 2024

FliegendeWurst left a comment

Choose a reason for hiding this comment