vimPlugins.neotest-playwright: add telescope dependency #319314
Conversation
|
Result of 1 package built:
|
|
Result of 1 package built:
|
…n this adapter is used NixOS/nixpkgs#319314
|
Result of 1 package built:
|
|
Result of 1 package built:
|
…n this adapter is used NixOS/nixpkgs#319314
|
I dont see telescope used in their demo, it seems to use the native neovim TUI vim.select ? Ain't that a convenience dependency ? |
From the logs of the nixvim test suite, it seems necessary: |
…n this adapter is used NixOS/nixpkgs#319314
|
I see
Would be nice to have a similar test in nixpkgs too. As you mentioned on chat, a requireCheck with neotest as dependency should catch this. |
There was a problem hiding this comment.
we tried to quickly add a test with @GaetanLepage but it seemed non trivial.
Hopefully #319325 will fix some stuff. We can revisit later.
Do as you prefer @GaetanLepage ;)
Yes, let us merge this as is. We'll see afterwards regarding testing as we might need the lua-paths fix... |
…n this adapter is used NixOS/nixpkgs#319314
…n this adapter is used NixOS/nixpkgs#319314
Description of changes
As mentioned in their README,
telescope.nvimis required.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.