prismlauncher: fix meta using lib.version instead of finalAttrs.version #277953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
There was an issue with the
meta.changelog
attribute usingversion
Looks like that before using
finalAttrs
, therec
keyword was overpowering thewith lib;
statement, soversion
would evaluate to the package version. However, after migrating tofinalAttrs
,version
still evaluates, but tolib.version
instead.I updated the meta to use
finalAttrs.version
.I have also removed the
with lib;
to make similar accidents less likely. (I can revert this if anyone's against it)Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.