Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buf: 1.20.0 -> 1.21.0 #236190

Merged
merged 1 commit into from
Jun 7, 2023
Merged

buf: 1.20.0 -> 1.21.0 #236190

merged 1 commit into from
Jun 7, 2023

Conversation

aaronjheng
Copy link
Contributor

@aaronjheng aaronjheng commented Jun 6, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from 06kellyjac and lrewega June 6, 2023 03:16
@aaronjheng aaronjheng marked this pull request as ready for review June 6, 2023 03:50
drupol
drupol approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drupol drupol merged commit ebd6b24 into NixOS:master Jun 7, 2023
@aaronjheng aaronjheng deleted the buf branch June 7, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@06kellyjac 06kellyjac Awaiting requested review from 06kellyjac

@lrewega lrewega Awaiting requested review from lrewega

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronjheng @drupol