Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache_datasketches: init at 1.6.0 #234987

Merged
merged 1 commit into from
Jun 2, 2023
Merged

apache_datasketches: init at 1.6.0 #234987

merged 1 commit into from
Jun 2, 2023

Conversation

mmusnjak
Copy link
Contributor

Description of changes

PostgreSQL extension providing approximate algorithms for distinct item counts, quantile estimation and frequent items detection.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 30, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels May 30, 2023
drupol
drupol requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must add the missing hooks in each phases of your derivation.

@mmusnjak
Copy link
Contributor Author

mmusnjak commented Jun 1, 2023

You must add the missing hooks in each phases of your derivation.

This should be done too

@drupol
Copy link
Contributor

drupol commented Jun 2, 2023

Don't forget to squash the commits.

@mmusnjak mmusnjak force-pushed the apache-datasketches branch from 0282846 to a924cca Compare June 2, 2023 09:20
@mmusnjak mmusnjak force-pushed the apache-datasketches branch 2 times, most recently from 0753c49 to 0d76da7 Compare June 2, 2023 09:27
@mmusnjak mmusnjak changed the title apache-datasketches: init at 1.6.0 apache_datasketches: init at 1.6.0 Jun 2, 2023
@mmusnjak mmusnjak force-pushed the apache-datasketches branch from 0d76da7 to 71f7e59 Compare June 2, 2023 10:39
@mmusnjak
apache_datasketches: init at 1.6.0
aafe0f4 
PostgreSQL extension providing approximate algorithms for
distinct item counts, quantile estimation and frequent items detection.
@mmusnjak mmusnjak force-pushed the apache-datasketches branch from 71f7e59 to aafe0f4 Compare June 2, 2023 19:03
drupol
drupol approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now finally :) Waiting for the eval to be done and merging this !

@drupol
Copy link
Contributor

drupol commented Jun 2, 2023

@GrahamcOfBorg build apache_datasketches
@GrahamcOfBorg test apache_datasketches

@drupol drupol merged commit 161182c into NixOS:master Jun 2, 2023
@mmusnjak
Copy link
Contributor Author

mmusnjak commented Jun 2, 2023

@drupol Thanks a lot for reviews and advice!

@mmusnjak mmusnjak deleted the apache-datasketches branch June 2, 2023 20:29
@drupol
Copy link
Contributor

drupol commented Jun 2, 2023

Thanks for your contribution and patience :)

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmusnjak @drupol @Janik-Haag