Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

antidote: init at 1.8.6 #234462

Merged
merged 1 commit into from
Jun 2, 2023
Merged

antidote: init at 1.8.6 #234462

merged 1 commit into from
Jun 2, 2023

Conversation

hitsmaxft
Copy link
Contributor

@hitsmaxft hitsmaxft commented May 27, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

antidote https://getantidote.github.io/

Antidote is a Zsh plugin manager made from the ground up thinking about performance.
It is fast because it can do things concurrently, and generates an ultra-fast static plugin file that you can easily load from your Zsh config.
It is written natively in Zsh, is well tested, and picks up where Antibody left off.

@hitsmaxft hitsmaxft changed the title antidote: init at version 1.8.3 antidote: init at version 1.8.6 May 27, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 27, 2023
@kilianar
Copy link
Contributor

You should consider adding yourself as a package maintainer in the meta attributes.

@hitsmaxft hitsmaxft requested a review from kilianar May 29, 2023 12:34
drupol
drupol requested changes May 31, 2023
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/antidote/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/antidote/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/antidote/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
drupol
drupol requested changes Jun 1, 2023
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/antidote/default.nix Outdated Show resolved Hide resolved
pkgs/shells/zsh/antidote/default.nix Outdated Show resolved Hide resolved
drupol
drupol requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing everything. Squash all the commits into one single commit and I'll merge this.

@drupol drupol changed the title antidote: init at version 1.8.6 antidote: init at 1.8.6 Jun 2, 2023
@drupol
Copy link
Contributor

drupol commented Jun 2, 2023 •
edited
Loading

The commit message is not correctly formatted.

It must follow our guidelines and therefore be antidote: init at 1.8.6

Same goes for the PR title, but I fixed it myself.

@hitsmaxft
Copy link
Contributor Author

antidote: init at 1.8.6

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
sorry
I just copy from others lol, now it fixed.

drupol
drupol requested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eval is broken because of that.

pkgs/shells/zsh/antidote/default.nix Outdated Show resolved Hide resolved
@hitsmaxft
Copy link
Contributor Author

Eval is broken because of that.

nix-build $(pwd) -A antidote --show-trace is ok, how to reproduce it locally

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jun 2, 2023
@hitsmaxft hitsmaxft requested a review from drupol June 2, 2023 08:57
drupol
drupol requested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits and let's wait for the end of all the evaluation before merging.

@hitsmaxft hitsmaxft requested a review from drupol June 2, 2023 10:47
@hitsmaxft
Copy link
Contributor Author

Please squash your commits and let's wait for the end of all the evaluation before merging.

done

@drupol
Copy link
Contributor

drupol commented Jun 2, 2023

@GrahamcOfBorg build antidote

@drupol drupol merged commit 37a6711 into NixOS:master Jun 2, 2023
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 13, 2023
@wolfgangwalther wolfgangwalther mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@kilianar kilianar Awaiting requested review from kilianar

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hitsmaxft @kilianar @drupol @Janik-Haag