Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vivictpp: init at 0.3.1 #229909

Merged
merged 1 commit into from
Jun 7, 2023
Merged

vivictpp: init at 0.3.1 #229909

merged 1 commit into from
Jun 7, 2023

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented May 4, 2023

Description of changes

Add vivictpp, "an easy to use tool for subjective comparison of the visual quality of different encodings of the same video source".

It allows you to play back two videos at the same time, and then use your cursor to reveal different portions of them for easy visual comparison.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Comment on lines 26 to 35
buildCommand = ''
cp -r --no-preserve=mode $src $out
cd $out

meson subprojects download
find subprojects -type d -name .git -prune -execdir rm -r {} +
'';

outputHashMode = "recursive";
outputHash = "sha256-J7B9l03r+D09a1mj6aChZfLHgYfNOJUHIpPr5LORKAE=";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sketchiest bit of the PR. It... should be stable, but it is still fragile to bunch up multiple sources like this. The alternative (interpreting .wrap files and placing the subprojects with nix) would need more reusable nixpkgs support though.

description = "An easy to use tool for subjective comparison of the visual quality of different encodings of the same video source";
homepage = "https://github.com/vivictorg/vivictpp";
license = licenses.gpl2Plus;
platforms = platforms.unix;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a guess.

The project's README says

Vivict++ is intended to be cross platform, so building on Windows or macOS should be possible. Testing and help would be appreciated.

I have no easy way of testing whether it builds/runs on darwin, or non-linux unix variants.

@tilpner tilpner changed the title vivictpp: init at 0.2.5 vivictpp: init at 0.3.1 May 17, 2023
@tilpner
Copy link
Member Author

tilpner commented May 17, 2023

Upstream released 0.3.1 since this PR was opened, which pulls in imgui. Imgui currently writes imgui.ini into the current working directory. I've opened a PR upstream to prevent that, and will update this PR if and when it's merged and a new version is released.

@Lassulus Lassulus merged commit 212c6fb into NixOS:master Jun 7, 2023
@tilpner tilpner deleted the init-vivictpp branch June 7, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants