-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vivictpp: init at 0.3.1 #229909
vivictpp: init at 0.3.1 #229909
Conversation
buildCommand = '' | ||
cp -r --no-preserve=mode $src $out | ||
cd $out | ||
|
||
meson subprojects download | ||
find subprojects -type d -name .git -prune -execdir rm -r {} + | ||
''; | ||
|
||
outputHashMode = "recursive"; | ||
outputHash = "sha256-J7B9l03r+D09a1mj6aChZfLHgYfNOJUHIpPr5LORKAE="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the sketchiest bit of the PR. It... should be stable, but it is still fragile to bunch up multiple sources like this. The alternative (interpreting .wrap
files and placing the subprojects with nix) would need more reusable nixpkgs support though.
description = "An easy to use tool for subjective comparison of the visual quality of different encodings of the same video source"; | ||
homepage = "https://github.com/vivictorg/vivictpp"; | ||
license = licenses.gpl2Plus; | ||
platforms = platforms.unix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a guess.
The project's README says
Vivict++ is intended to be cross platform, so building on Windows or macOS should be possible. Testing and help would be appreciated.
I have no easy way of testing whether it builds/runs on darwin, or non-linux unix variants.
Upstream released 0.3.1 since this PR was opened, which pulls in imgui. Imgui currently writes imgui.ini into the current working directory. I've opened a PR upstream to prevent that, and will update this PR if and when it's merged and a new version is released. |
Description of changes
Add vivictpp, "an easy to use tool for subjective comparison of the visual quality of different encodings of the same video source".
It allows you to play back two videos at the same time, and then use your cursor to reveal different portions of them for easy visual comparison.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)