Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has: init at 1.4.0 #202338

Merged
merged 1 commit into from
Jun 3, 2023
Merged

has: init at 1.4.0 #202338

merged 1 commit into from
Jun 3, 2023

Conversation

Freed-Wu
Copy link
Contributor

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Freed-Wu
Copy link
Contributor Author

Any problem?

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Feb 2, 2023

Can anyone review this PR? Thanks!

drupol
drupol requested changes Jun 2, 2023
View reviewed changes
pkgs/applications/misc/has/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/has/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/has/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/has/default.nix Outdated Show resolved Hide resolved
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jun 2, 2023

Fixed.

drupol
drupol requested changes Jun 2, 2023
View reviewed changes
pkgs/applications/misc/has/default.nix Outdated Show resolved Hide resolved
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jun 2, 2023

Fixed.

drupol
drupol requested changes Jun 2, 2023
View reviewed changes
pkgs/applications/misc/has/default.nix Outdated Show resolved Hide resolved
drupol
drupol requested changes Jun 2, 2023
View reviewed changes
pkgs/applications/misc/has/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/has/default.nix Outdated Show resolved Hide resolved
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jun 3, 2023

Fixed.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jun 3, 2023
@drupol drupol merged commit 1b79f9b into NixOS:master Jun 3, 2023
@Freed-Wu Freed-Wu deleted the has branch June 3, 2023 05:31
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Freed-Wu @drupol @Janik-Haag