Add getters for the library version #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake generates version.h from version.h.in and sets the major and minor
version as specified in CMakeLists.txt and the current git version as
returned by `git describe --always`. These values are also added to the
C API as NK_get{_major,_minor,}_library_version.
szszszsz
approved these changes
Jun 19, 2018
szszszsz
approved these changes
Jun 19, 2018
|
|
||
| namespace nitrokey { | ||
| unsigned int get_major_library_version() { | ||
| return @PROJECT_VERSION_MAJOR@; |
There was a problem hiding this comment.
Implementation in header file makes a small problem - it will probably not be possible (until some compiler/optimization trick is used) to use these functions in other compilation units (e.g. in C++ API - NitrokeyManager) due to name's clash. Otherwise all good!
I will split it to .h and .cc and merge.
There was a problem hiding this comment.
Great! Can you have another look at the test case? I think it will fail if you are on a release commit, see this comment.
sgued
pushed a commit
to sgued/libnitrokey
that referenced
this pull request
Feb 14, 2022
Due to NetHSM issue Nitrokey#117, the generated API client currently does not work for the /keys/{key_id}/cert endpoint. Therefore, this patch replaces the generated code with a manual implementation.
sgued
pushed a commit
to sgued/libnitrokey
that referenced
this pull request
Feb 14, 2022
nk3: Remove unnecessary print statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake generates
version.hfromversion.h.inand sets the major and minor version as specified in CMakeLists.txt and the current git version as returned bygit describe --always. These values are also added to the C API asNK_get{_major,_minor,}_library_version.This patch fixes issue #35 and is based on the pull request #62, addressing the issues mentioned in the discussion.