Safely removing running sequences #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some cases where one sequence in callback stops another sequence. Previously, this could modify table _runningSequences in a loop of Sequence.update().
Fixed that: if you used sequence.time or sequence:get() in callback of sequence, you got not actual information from sequence.
Update print function sequence.print()
Fixed some cases, when you could get two same called callbacks in sequence (when cbObject.timestamp==clampedStart)
Floating point calculations lead to inaccuracies (some callbacks could be not called)
|
@NicMagnier please find the time to review this pull request. The author says that when using the library, rare but serious bugs appear, and that he solved them in this PR. |
rename some functions to be clearer triggerCallbacks() behavior does not depending of logic when it is called (not fixing dt past call) better clarifty for edge case in triggerCallbacksClampedTimeRange clearer conversion to milliseconds
|
Some good fix in there. I've refactor some part of the class to be make the changes clearer. For the future I would also recommend to make different PR because that helps fixing issue one at a time |
|
@NicMagnier I have checked the latest changes with my test cases. Everything is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some cases where one sequence in callback stops another sequence. Previously, this could modify table _runningSequences in a loop of Sequence.update().