Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: Bannerlord Diagnostics & Misc Improvements #2252

Merged
merged 19 commits into from
Nov 18, 2024
Merged

Added: Bannerlord Diagnostics & Misc Improvements #2252

merged 19 commits into from
Nov 18, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Nov 18, 2024

Changelog (simplified):

  • Diagnostics: As demo'd last week.
    • Includes dummy mods to replicate every possible diagnostic.
  • Synchronizer: Skip backup of base game mods/modules.
    • Only backup core binaries and module metadata, for future display purposes.

Related:

Most of the diagnostics code/improvements were submitted upstream, to the codebase shared by multiple mod managers.
So there isn't much here to review, mainly a lightweight integration of the tech, and the other misc changes.

Sewer56 and others added 16 commits November 6, 2024 01:56
@Sewer56
Added: Filters around native game modules.
0e2bee9
@Sewer56
Added: Filter out base game extra folders
aaa63b9
@Sewer56
Merge remote-tracking branch 'erri120/main' into bannerlord-diagnostics
23695cd
@Sewer56
Added: Force Backup List for all built-in modules, required for diagn…
6206fa6 
…ostics.
@Sewer56
Added: Integration for ModuleManager Diagnostics [untested]
ccee444
@Sewer56
Merge remote-tracking branch 'origin/main' into bannerlord-diagnostics
6c845de
@Sewer56
Removed: Unused local variables.
c374224
@Sewer56
Merge remote-tracking branch 'erri120/main' into bannerlord-diagnostics
2531b49
@Sewer56
Added: Misc Fixes to Dependency Descriptions
1066a80
@insomnious @Sewer56
Added ScrollViewer around health check markdown
a4ba0d0
@Sewer56
Improve: Note in Diagnostic emitter that logger is read only.
b1ce020
@Sewer56
Improved: Apply feedback from end user testing of errors.
455a859
@Sewer56
Added: Dummy Mods for Testing Diagnostics
56efdfe
@Sewer56
Bumped: ModuleManager Version
0226847
@Sewer56
Removed: Unused DiagnosticRecords Class
e7333e4
@Sewer56
Improved: Description of backup/dontbackup list
1225351
@Sewer56 Sewer56 requested a review from a team November 18, 2024 07:02
@Sewer56 Sewer56 self-assigned this Nov 18, 2024
@Sewer56 Sewer56 mentioned this pull request Nov 18, 2024
Open
@Al12rs Al12rs self-requested a review November 18, 2024 09:47
Al12rs
Al12rs approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback above, can either be handled in this PR or in follow up one

@Al12rs Al12rs merged commit 23fd1da into main Nov 18, 2024
12 checks passed
@Al12rs Al12rs deleted the bannerlord-diagnostics branch November 18, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al12rs Al12rs Al12rs approved these changes

Assignees

@Sewer56 Sewer56

Labels
Epic: Game Support
Projects
MVP
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sewer56 @Al12rs @insomnious