Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nd-common): mutating webhook not working for single pod istio proxy sidecar injection #332

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(nd-common): mutating webhook not working for single pod istio proxy sidecar injection #332

merged 1 commit into from
Sep 5, 2024
+3 −2

Conversation

schahal
Copy link
Contributor

@schahal schahal commented Sep 5, 2024

The istio mutating webhook config can look something like this:

  Object Selector:
    Match Expressions:
      Key:       sidecar.istio.io/inject
      Operator:  NotIn
      Values:
        false
      Key:       istio.io/rev
      Operator:  In
      Values:
        stable

... for namespaces that are configured to be off the mesh, we'd need this change to allow single pods within that namespace to be a part of the mesh.

@schahal schahal requested a review from a team as a code owner September 5, 2024 19:14
@schahal schahal merged commit 41fbd32 into main Sep 5, 2024
2 checks passed
@schahal schahal deleted the fix/support-single-pod-proxy-sidecar branch September 5, 2024 19:20
@schahal schahal mentioned this pull request Sep 5, 2024
Merged
schahal added a commit that referenced this pull request Sep 5, 2024
@schahal
fix(simple-app): update nd-common for single pod istio proxy sidecar …
e6dca1d 
…injection (#333)

To pull in this fix: #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlava stlava

@diranged diranged

@scohen-nd scohen-nd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schahal @stlava