Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster fetch dandisets #292

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Faster fetch dandisets #292

merged 9 commits into from
Jun 16, 2023

Conversation

luiztauffer
Copy link
Collaborator

Fetches dandisets metadata faster using multithreading

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #292 (90584d3) into master (f674eff) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   66.18%   66.28%   +0.09%     
==========================================
  Files          35       35              
  Lines        3460     3470      +10     
==========================================
+ Hits         2290     2300      +10     
  Misses       1170     1170              
Flag Coverage Δ
unittests 66.28% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/panel.py 78.10% <100.00%> (+1.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luiztauffer luiztauffer requested a review from bendichter June 16, 2023 12:35
nwbwidgets/panel.py Outdated Show resolved Hide resolved
nwbwidgets/panel.py Outdated Show resolved Hide resolved
@luiztauffer
Copy link
Collaborator Author

@bendichter you need to approve it to be merged

@bendichter bendichter self-requested a review June 16, 2023 15:18
@bendichter bendichter merged commit b99aa49 into master Jun 16, 2023
@bendichter bendichter deleted the faster-fetch-dandisets branch June 16, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants