Added ExternalId to sts.assume_role calls. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Were you able to test that this works? |
|
I tested it briefly in a REPL using some of the examples in the README and it works as far as I can tell. |
|
Please bump up the version number in After that, update the SM requirements to pin to that version. |
|
Minor or patch? |
|
|
dgreene-r7
added a commit
to dgreene-r7/security_monkey
that referenced
this pull request
Aug 1, 2018
|
Pushed 1.5.0 to PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
ExternalIdto allsts.assume_rolecalls.See Netflix/security_monkey#1101 and Netflix/security_monkey#1100.