Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(h5): 修复createAnimation单位判定/添加测试 #2755

Merged
merged 1 commit into from
Apr 19, 2019
Merged

fix(h5): 修复createAnimation单位判定/添加测试 #2755

merged 1 commit into from
Apr 19, 2019

Conversation

zWingz
Copy link
Contributor

@zWingz zWingz commented Apr 13, 2019

fix #2749

  • 修复createAnimation对单位判定, 根据wx.createAnimation参数, 如果传入为number则默认带上px, 否则延用参数值
  • 添加相应测试

@zWingz
Copy link
Contributor Author

zWingz commented Apr 13, 2019 •
edited
Loading

对于videoUtils和imageUtils这两个文件是一样的, 而且同时导出了chooseImage

导致index.js有重复导出
本地测试会不通
image

我不知道官方对此是怎么看, 因此没有改这部分代码

@zWingz
Copy link
Contributor Author

zWingz commented Apr 13, 2019 •
edited
Loading

对于运行h5测试步骤也有些许疑惑

  • npm run bootstrap 安装完依赖
  • cd packages/taro-h5
  • npm run test

在packages/taro/index.js中

module.exports = require('./dist/index.js').default // 报错
module.exports.default = module.exports

image

之后需在packages/taro中执行rollup打包后方可运行
不明其意, 不敢乱改..

@luckyadam
Copy link
Member

@zWingz 先编译再跑测试咯

@zWingz
Copy link
Contributor Author

zWingz commented Apr 13, 2019

@luckyadam 目前是这样

@Littly Littly self-requested a review April 18, 2019 02:29
Littly
Littly approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@Littly Littly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以可以 这样就更全面一些了

@Littly Littly merged commit 54b2404 into NervJS:master Apr 19, 2019
Littly added a commit that referenced this pull request Apr 19, 2019
@Littly
fix(h5): 修复createAnimation单位判定/添加测试 (#2755)
049a994
@taro-bot taro-bot bot mentioned this pull request Apr 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Littly Littly Littly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

h5的Taro.createAnimation单位问题
3 participants
@zWingz @luckyadam @Littly