Fix installation on Python 3.8 due to missing Tensorflow-io wheel #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
juhoinkinen
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 89 89
Lines 6404 6404
=======================================
Hits 6383 6383
Misses 21 21 ☔ View full report in Codecov by Sentry. |
juhoinkinen
added a commit
that referenced
this pull request
Feb 2, 2024
This was referenced Feb 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorFlow IO v0.35.0 was released in December 19th. That release in PyPI does not provide many platform wheels that were provided by v0.34.0. See the tracking issue tensorflow/io#1906.
Now Annif installation with NN ensemble backend fails on Python 3.8 (there were some failed CI runs).
We may want to drop support for Python 3.8 for Annif v1.1, but for the meantime, this fixes the installation by making TensorFlow IO a direct dependency for Python 3.8 and pins its version to 0.34.*.