Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions workflow: Do not require "publish Docker latest" before "publish release" #714

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

juhoinkinen
Copy link
Member

I tried to streamline the CI/CD workflow by making "publish release" job to require "publish latest Docker image" job in #712.

I did not consider that the "publish latest Docker image" job is skipped for tag events, and so also the "publish release" job would be skipped and never run.

Better to revert back to the previous configuration, where both jobs in question require the same test/lint jobs.

@juhoinkinen juhoinkinen added the bug label Jun 9, 2023
@juhoinkinen juhoinkinen added this to the 1.0 milestone Jun 9, 2023
@juhoinkinen juhoinkinen merged commit 51db308 into main Jun 9, 2023
@juhoinkinen juhoinkinen deleted the fix-gh-actions-job-order branch June 9, 2023 12:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant