Add log message indicating finishing projects initialization #671
Conversation
There was a problem hiding this comment.
Seems like a useful feature. 👍
As you noted, the different log messages are in different formats and some of them are less useful than others. We also have an old issue #451 which is somewhat related to the problem of handling log messages. IIRC Omikuji does its own logging from within Rust code, and it can be difficult or impossible to control that. Not sure about if and how gunicorn logging could be controlled.
|
SonarCloud Quality Gate failed.
|
Codecov ReportBase: 99.56% // Head: 99.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 99.56% 99.12% -0.44%
==========================================
Files 87 87
Lines 6142 6145 +3
==========================================
- Hits 6115 6091 -24
- Misses 27 54 +27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
By looking at the logs from e.g. OpenShift environment it can be hard to see if Annif pod/container has booted or models are still being loaded. In error situations while Annif is in boot loop (or it seems so) it would be good to easily know from the logs if/when Annif has started.
This PR adds an info level message
finished initializing projectsto log stream for addressing the mentioned concern. For this, it was necessary to also do the basic configuration for the root logger and set log level to "info" (was "unset") for "annif" logger. This makes all log messages from Annif to show also the level and the logger name.For example:
The gunicorn and Omikuji log messages have also timestamps, but they are actually more distracting than helpful when logs are read in Kibana (especially), because there is a dedicated timestamp field for every message.