Update dependencies v0.60 #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning was necessary due to issue #565, coverage v6.4 should have the underlying problem fixed
Codecov ReportBase: 99.55% // Head: 99.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 87 87
Lines 6006 6006
=======================================
Hits 5979 5979
Misses 27 27 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all outdated dependencies.
I tested backward compatibility of (some) models by training and evaluating tfidf, fasttext, omikuji, and NN models on the fulltext archaelogy corpus with Annif 0.59, and then evaluating them with this PR applied: the evaluation results are identical.
The coverage package is removed from the direct dependencies to unpin it as the underlying problem is resolved in coverage 6.4.
(I noticed Pandas gets installed as the dependency of fuzzytm, which is a dependency of the updated gensim. I thought Pandas would take quite much space, but fortunately now the Docker image size is actually smaller than with Annif 0.59: 2.02GB vs 1.9 GB).