Install linting tools with Poetry in CI/CD pipeline #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.55% // Head: 99.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 87 87
Lines 6006 6006
=======================================
Hits 5979 5979
Misses 27 27 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…sion with env for the job
juhoinkinen
force-pushed
the
drop-linting-gh-actions
branch
from
c6a6f61 to
3632bfe
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
juhoinkinen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #650, this PR switches installing isort and Black from PyPI with Poetry (instead of using the GH Actions) and flake8 with Poetry, so now the versions of these tools are the same in CI/CD and in local installations (maybe depending on the Python versions in the environments; in CI/CD linting job I chose to use Python 3.10). Also this approach might be a little more secure way to install the tools as it does not rely on the GH Actions.
Downside is longer and more complex definition.