Add project info to web UI #654
Conversation
Codecov ReportBase: 99.55% // Head: 99.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 87 87
Lines 6006 6006
=======================================
Hits 5979 5979
Misses 27 27 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Great work so far! I think the visual design could be a bit simpler instead of a big button. How about making it similar to the collapsible details/summary view available here on GitHub, something like this (try clicking): Project informationProject ID: yso-fiLanguage: fi Backend type: nn_ensemble Trained: yes Last modified: 2022-11-21 15:07:57 UTC Here is a rough sketch how it could look (sorry for the bad alignment, not intended!)
It would be closed by default of course. |
|
I changed it to this now: I left the animation for the collapse element on but it can be removed too if it's distracting. |
There was a problem hiding this comment.
This is excellent! I think the animation is also OK.
A couple of very minor visual details that you could perhaps address:
- "Project information" is now set in bold - I think it could be just regular text. Now it stands out more than necessary, because there is no other bold text on the page.
- Is there any chance to left-align the text column so that "Project information" and "Project ID" would be aligned?
Other than these two minor details, I think this is good for merging!
|
Kudos, SonarCloud Quality Gate passed!
|
|
We should remember to update the Wiki page for the Web UI when the next release is made, it is quite old already. |
This PR adds information about a selected project to the web UI.
A button is added under the project selection:
This opens a box with the information on the project:
IMO a version with the info in a popup next to the project selection would look cleaner but I'm not sure how to implement it yet.