Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Bootstrap to version 5.2.2 #648

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Upgrade Bootstrap to version 5.2.2 #648

merged 1 commit into from
Nov 25, 2022

Conversation

UnniKohonen
Copy link
Contributor

This PR upgrades Bootstrap from version 4.5.0 to 5.2.2 in the web UI. Also makes small changes to html and css to fix errors resulting from the upgrade.

@UnniKohonen UnniKohonen requested a review from osma November 23, 2022 13:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma osma added this to the 0.60 milestone Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited
Loading

Codecov Report

Base: 99.54% // Head: 99.54% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (baf1836) compared to base (0b428a7).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          87       87           
  Lines        5968     5988   +20     
=======================================
+ Hits         5941     5961   +20     
  Misses         27       27
Impacted Files Coverage Δ
annif/parallel.py 100.00% <0.00%> (ø)
annif/registry.py 100.00% <0.00%> (ø)
tests/test_cli.py 100.00% <0.00%> (ø)
tests/test_parallel.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

osma
osma approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested the PR. There are minor changes in the layout: the content area is a little wider, and the circular buttons with the different limit values (10, 15, 20) are a bit further apart than before. But these are not important regressions. Good for merging!

@UnniKohonen UnniKohonen merged commit 4beebe9 into master Nov 25, 2022
@UnniKohonen UnniKohonen deleted the bootstrap-5.2.2-upgrade branch November 25, 2022 11:53
@osma osma mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osma osma osma approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.60
Development

Successfully merging this pull request may close these issues.
2 participants
@UnniKohonen @osma