Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use axios in web UI; remove jQuery #646

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Use axios in web UI; remove jQuery #646

merged 4 commits into from
Nov 29, 2022

Conversation

UnniKohonen
Copy link
Contributor

This PR replaces the jQuery ajax calls in the web UI with methods from the Axios library.

@UnniKohonen UnniKohonen requested a review from osma November 21, 2022 10:35
@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Base: 99.55% // Head: 99.55% // No change to project coverage 👍

Coverage data is based on head (1a42edc) compared to base (26a405c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          87       87           
  Lines        6006     6006           
=======================================
  Hits         5979     5979           
  Misses         27       27

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@UnniKohonen UnniKohonen added this to the 0.60 milestone Nov 24, 2022
@osma
Copy link
Member

osma commented Nov 25, 2022

Now that the Bootstrap 5 upgrade has been merged (#648), I suggest merging current master into this branch (or rebasing on master if you like) so you get the new Bootstrap, which doesn't depend on jQuery. Then it should be possible to remove jQuery entirely in this PR.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@UnniKohonen UnniKohonen marked this pull request as ready for review November 29, 2022 10:58
osma
osma approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works perfectly! Thanks a lot

@UnniKohonen UnniKohonen merged commit c48d81a into master Nov 29, 2022
@UnniKohonen UnniKohonen deleted the use-axios-in-web-ui branch November 29, 2022 12:28
@osma osma changed the title Use axios in web UI Use axios in web UI; remove jQuery Jan 20, 2023
@juhoinkinen juhoinkinen mentioned this pull request Feb 23, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osma osma osma approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.60
Development

Successfully merging this pull request may close these issues.
2 participants
@UnniKohonen @osma