Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING.md file #643

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Add CONTRIBUTING.md file #643

merged 6 commits into from
Nov 21, 2022

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Nov 15, 2022 •
edited
Loading

Adding this information hopefully helps newcomers when they wish to participate in Annif development.

Some parts are borrowed from Annif wiki and some from the corresponding file of Skosmos.

On next release, the parts taken here from Annif wiki should be deleted from there to avoid duplication (Development flow, branches and tags and Creating a new backend).

@juhoinkinen juhoinkinen added this to the 0.60 milestone Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

Base: 99.58% // Head: 99.54% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (74ce87b) compared to base (63af34c).
Patch has no changes to coverable lines.

❗ Current head 74ce87b differs from pull request most recent head 45070c8. Consider uploading reports for the commit 45070c8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   99.58%   99.54%   -0.04%     
==========================================
  Files          87       87              
  Lines        5972     5968       -4     
==========================================
- Hits         5947     5941       -6     
- Misses         25       27       +2
Impacted Files Coverage Δ
annif/transform/__init__.py 93.75% <0.00%> (-6.25%) ⬇️
annif/transform/langfilter.py 100.00% <0.00%> (ø)
tests/test_transform_langfilter.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

osma
osma reviewed Nov 15, 2022
View reviewed changes
README.md Show resolved Hide resolved
@osma
Copy link
Member

osma commented Nov 15, 2022

Here are some more ideas for what to include in a CONTRIBUTING.md file.

@juhoinkinen juhoinkinen marked this pull request as ready for review November 18, 2022 14:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@juhoinkinen juhoinkinen merged commit 0b428a7 into master Nov 21, 2022
@juhoinkinen juhoinkinen deleted the add-contributing-file branch November 21, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osma osma osma left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
0.60
Development

Successfully merging this pull request may close these issues.
2 participants
@juhoinkinen @osma